Issue in adding rust lightning as dependency on windows #2607
Conversation
|
I think you can just enable symbolic link support when installing Git for Windows. You'll then want to set after which you should be able to checkout |
|
Ok, but this change looks good to go right ? |
Not sure, not too long ago @TheBlueMatt pushed back on removing the symlink: #2377. |
|
I'm not a fan of removing the symlink if we need the dup code, but we don't actually use |
No longer needed time_utils in lightning-invoice
DhananjayPurohit
force-pushed
the
civkit-branch
branch
from
c587cc0 to
cf0cef8
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
==========================================
- Coverage 90.34% 88.96% -1.39%
==========================================
Files 106 112 +6
Lines 55093 86199 +31106
Branches 55093 86199 +31106
==========================================
+ Hits 49773 76683 +26910
- Misses 5320 7285 +1965
- Partials 0 2231 +2231
☔ View full report in Codecov by Sentry. |
I am having issue in adding rust-llightning as dependency on my windows machine. On debugging, I found this submodule icon inside
/lightning-invoice/src:-The file
lightning-invoice/src/time_utils.rscontains symbolic link to/lightning/src/util/time.rswhich is followed fine on unix and darwin but not on windows.It appears that
lightning-invoice/src/time_utils.rsis no longer needed. I have tried fixing that in this PR.@ariard